-
-
Notifications
You must be signed in to change notification settings - Fork 632
fix(schema-migration): more robust migration of background-color & text-color attributes #2154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
9ad7185 to
a0bd4ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This makes some changes to the schema migration to make it slightly more robust. It now:
firstChild) & is trying to update the content of the document, reducing likelihood of race conditions with networkRationale
The schema migration was introduced to allow for a client-side migration allowing some of the default attributes (backgroundColor & textColor) on the blockContainer, to be moved to it's containing block. This makes that migration more robust & likely to succeed in migrating the content.
Changes
See above
Impact
Testing
You can create an old YDoc by switching to a previous version of BlockNote & adding some background color & text colors to a block. Then in the current version, you can try to load that document & it should attempt to migrate the colors since it has detected that they were on the incorrect element (present on the blockContainer).
Screenshots/Video
Checklist
Additional Notes